[3.15] gh-148587: Make sys.lazy_modules match PEP and keep internal lazy submodules tra…#150014
Merged
Conversation
DinoV
changed the title
DinoV
changed the title
DinoV
requested review from
FFY00,
Yhg1s,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan,
pablogsal and
warsaw
as code owners
Yhg1s
approved these changes
May 18, 2026
Member
Yhg1s
left a comment
Yhg1s
left a comment
There was a problem hiding this comment.
I think this approach makes sense...
Member
|
This went directly into |
This was referenced May 19, 2026
Member
Correct, thank you for catching that. Great work @DinoV! This was the cleanest idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PEP initially set
sys.lazy_moduleswas to be a set of the lazily imported things. At some point it seemed that having our internal tracking for publishing submodules to parent modules when they're imported could be combined with this. But this means that data the interpreter is making decisions on is now immutable. This goes back to having a separate set for the lazy modules which is user visible but has no impact on how lazy imports are evaluated or executed.This is one possible approach - another one would be to make it a function and calculate the set and return it per-call. Then it would be backed by our normal internal data.
We could also make it a function and keep tracking both sets of data as this PR does and then that'd give us the ability in the future to lazily calculate the data.
sys.lazy_modules#148587