Skip to content

gh-155468: Distinguish empty quoted tokens from EOF in netrc - #155471

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
lpyu001:netrc
Aug 27, 2026
Merged

gh-155468: Distinguish empty quoted tokens from EOF in netrc#155471
serhiy-storchaka merged 2 commits into
python:mainfrom
lpyu001:netrc

Conversation

@lpyu001

@lpyu001 lpyu001 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Comment thread Lib/netrc.py Outdated
Comment thread Lib/netrc.py Outdated
Comment thread Lib/test/test_netrc.py

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@lpyu001

lpyu001 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

I've updated it based on the review comments. Could you take another look? @picnixz

@serhiy-storchaka
serhiy-storchaka merged commit 2a37d67 into python:main Aug 27, 2026
55 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 27, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @lpyu001 and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2a37d678ee96bba13e58e68020ccdcf666ff23a3 3.14

@bedevere-app

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156464 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 27, 2026
@miss-islington-app

Copy link
Copy Markdown

Sorry, @lpyu001 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2a37d678ee96bba13e58e68020ccdcf666ff23a3 3.13

@bedevere-app

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156468 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 27, 2026
@bedevere-app

bedevere-app Bot commented Aug 27, 2026

Copy link
Copy Markdown

GH-156469 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants