gh-155877: Reject a NUL sharing a curses cell, keep a lone one - #156158
Merged
Conversation
setcchar() takes a NUL-terminated string, so a NUL in a cell dropped the
rest of it: complexchar('a\0' + combining) kept only 'a', and an empty cell
read back as complexchar('') rather than complexchar('\0') as on a narrow
build. Reject a NUL among other characters, read an empty cell as a NUL,
and give a NUL its own cell in complexstr().
A NUL cell ends a batch write and a cell array read (add_wchnstr(3X)), so addstr() would write only the cells before it and in_wchstr() would read only those, on both a wide and a narrow build. addstr() already rejects an embedded NUL in a str.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #155878.
setcchar()takes a NUL-terminated string, so a NUL sharing a cell with other characters dropped the rest of the cell, and an empty cell read back ascomplexchar(''), which is not a valid constructor call.Reject a NUL among other characters, read an empty cell as a NUL, as the narrow build already does, and give a NUL its own cell in
complexstr().A lone NUL stays a character:
complexchar('\0')works andaddch(complexchar('\0'))writes whataddch(0)writes.No NEWS entry: the cell API has not been released.