gh-156233: Fix grammar in MRO documentation - #156320
Closed
aryansk wants to merge 1 commit into
Closed
Conversation
Fixes python#156233 The sentence "Then repeat the operation until all the class are removed..." incorrectly uses singular "class". Change to "all the classes are removed" to match plural subject. Validation: git diff --check clean; verified rendering of Doc/howto/mro.rst via local inspection.
Documentation build overview
|
|
Thanks very much for sharing this. However, I think this is now redundant with #156475 (I had already agreed to fix this issue I discovered/reported before you opened this PR) which also fixes another typo and a couple of code snippet errors, so you can probably go ahead and close this PR. If you would like me, going forward, to provide you suspected typos and other documentation errors to send PRs for and follow to resolution, let me know and I can divvy up what I find in the future and offer to assign some to you. |
Member
|
Closing in favour of #156475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156233
Problem
Doc/howto/mro.rst contains a grammar typo:
Singular "class" disagrees with plural verb "are". The sentence describes removing multiple classes during MRO merge, so plural "classes" is correct.
Issue: #156233
Source:
Doc/howto/mro.rst:192(Doc/howto/mro.html#python-2-3-mro)Change
Doc/howto/mro.rst:192fromall the class are removed→all the classes are removedWhy this approach
Minimal one-line docs fix matching the issue's suggested correction. No code or behavior change.
Testing
Doc build:
Doc/howto/mro.rstrenders as before with corrected grammar; no functional tests required for docs-only change.Documentation and release impact
Review notes