-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
gh-156414: Document tomllib's limits & "extensions" #156415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
encukou
wants to merge
1
commit into
python:main
Choose a base branch
from
encukou:toml-docs-clarification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -157,3 +157,48 @@ Conversion Table | |||||||||
| +------------------+--------------------------------------------------------------------------------------+ | ||||||||||
| | array of tables | list of dicts | | ||||||||||
| +------------------+--------------------------------------------------------------------------------------+ | ||||||||||
|
|
||||||||||
| Limits and interoperability considerations | ||||||||||
| ------------------------------------------ | ||||||||||
|
|
||||||||||
| :mod:`!tomllib` places some limits on the documents it can handle, | ||||||||||
| and it preserves details that other TOML parsers are allowed to ignore. | ||||||||||
| When writing portable TOML files, consider only using features that are | ||||||||||
| guaranteed or recommended by the standard. | ||||||||||
|
|
||||||||||
| The implementation details listed here may change in future versions of Python. | ||||||||||
|
|
||||||||||
| Tables/dicts | ||||||||||
| Key/value pairs in TOML documents and tables are not guaranteed to be | ||||||||||
| in any specific order. | ||||||||||
|
Comment on lines
+172
to
+173
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be something like
Suggested change
As is I found it a bit unclear whether the unconditional mention of "Key/value pairs in TOML documents and tables" refers to the spec or the concrete impolementation. |
||||||||||
|
|
||||||||||
| .. impl-detail:: | ||||||||||
| :mod:`!tomllib` loads dictionary entries in the order they appear in | ||||||||||
| the source. | ||||||||||
|
|
||||||||||
| Integers | ||||||||||
| TOML recommends supporting integers in ``range(−2**63, 2**63)``. | ||||||||||
|
|
||||||||||
| .. impl-detail:: | ||||||||||
| :mod:`!tomllib` uses :ref:`Python's limit on integer string conversion | ||||||||||
| <int_max_str_digits>` (4300 digits by default). | ||||||||||
|
|
||||||||||
| Floats | ||||||||||
| TOML recommends supporting at least IEEE 754 binary64 values, | ||||||||||
| which means that numbers with more than 15 significant decimal digits | ||||||||||
| are likely to be rounded. | ||||||||||
|
|
||||||||||
| .. impl-detail:: | ||||||||||
| :mod:`!tomllib` uses Python :class:`float` by default; | ||||||||||
| on many common platforms this is the recommended binary64. | ||||||||||
| See :data:`sys.float_info` for details. | ||||||||||
|
|
||||||||||
| Nesting limit | ||||||||||
| TOML 1.1.0 does not recommend a limit on how deeply arrays and tables | ||||||||||
| may be nested inside one another. | ||||||||||
| (A limit of 100 has been proposed for a future version of TOML.) | ||||||||||
|
|
||||||||||
| .. impl-detail:: | ||||||||||
| In :mod:`!tomllib`, the nesting level is mainly limited by Python's | ||||||||||
| :func:`recursion limit <sys.getrecursionlimit>`. | ||||||||||
| Note that code that calls :mod:`!tomllib` may contribute to the limit. | ||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't hedge, this is the only way to be portable