gh-109714: Pass the file name and a message when raising OSError subclasses - #156441
Draft
serhiy-storchaka wants to merge 1 commit into
Draft
gh-109714: Pass the file name and a message when raising OSError subclasses#156441serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…r subclasses * Pass the file name as the filename argument instead of interpolating it into the message, so that it is available as the filename attribute: in shutil, logging.config, turtle, zipfile.Path and importlib.resources. * Give an explicit message where the one derived from errno would be misleading: "timed out" for timeouts which are not connection timeouts, and "No such resource" in importlib.resources. * In Tools, which is run with older Pythons too, pass errno explicitly. * Add _PyErr_SetOSErrorWithMessage() for raising an OSError subclass with an errno which is not the default one of the class. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #156430 for the filename keyword argument.
filenameattribute: inshutil,logging.config,turtle,zipfile.Pathandimportlib.resources.asyncio,concurrent.futures,multiprocessing), and "No such resource" inimportlib.resources.Tools, which is run with older Pythons too, pass errno explicitly._PyErr_SetOSErrorWithMessage()for raising anOSErrorsubclass with an errno which is not the default one of the class —PermissionErrorwithEINVALinremote_debug.h.