gh-156379: Avoid materializing large sequence ranges in mailbox.MH.get_sequences - #156442
Open
sundeep8967 wants to merge 1 commit into
Open
gh-156379: Avoid materializing large sequence ranges in mailbox.MH.get_sequences#156442sundeep8967 wants to merge 1 commit into
sundeep8967 wants to merge 1 commit into
Conversation
….MH.get_sequences Intersect declared ranges directly with all_keys instead of enumerating the entire interval into a set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
mailbox.MH.get_sequences(), sequence ranges declared in.mh_sequences(e.g.1-10000000) previously materialized every single integer in the interval (keys.update(range(start, stop + 1))) before filtering againstall_keys. For small mailboxes with wide sequence range definitions, this resulted in unnecessary memory allocation and CPU overhead.This PR optimizes
get_sequences()to intersect declared ranges directly with existing mailbox keys (all_keys), reducing execution time by orders of magnitude (~9000x on 10M ranges) and eliminating redundant memory allocation while preserving exact ordering and format validation semantics.Issue reference
Fixes gh-156379