gh-153569: return tokenizer tokens as source spans - #156482
Draft
pablogsal wants to merge 2 commits into
Draft
Conversation
Member
Author
|
Do not review until #156472 lands. |
pablogsal
force-pushed
the
gh-153569-tokenizer-offset-state
branch
from
August 28, 2026 15:32
dddc133 to
1753605
Compare
Member
Author
|
#156472 has landed; this is rebased on it now. |
pablogsal
force-pushed
the
gh-153569-tokenizer-offset-state
branch
from
August 28, 2026 16:24
1753605 to
8bd1d3a
Compare
pablogsal
changed the title
pablogsal
force-pushed
the
gh-153569-tokenizer-offset-state
branch
from
August 28, 2026 18:08
8bd1d3a to
c10fd82
Compare
pablogsal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizer currently returns pointers into its active input buffer. This switches that result to a logical source span with start/end locations, then updates pegen and
_tokenizeto consume the span directly.File and readline input keep a bounded active window and advance an absolute source offset when it is reused. Prepared and interactive input keep their SourceText backing. Buffer relocation is centralized, and the old returned-token pointers,
tok_state.end, and reserve-buffer API are gone. This is the next chunk of #153569 after #156472.