gh-155813: Stop overwriting LIBFFI_CFLAGS and LIBFFI_LIBS on macOS - #156486
Open
advitrocks9 wants to merge 1 commit into
Open
gh-155813: Stop overwriting LIBFFI_CFLAGS and LIBFFI_LIBS on macOS#156486advitrocks9 wants to merge 1 commit into
advitrocks9 wants to merge 1 commit into
Conversation
advitrocks9
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
August 27, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
configuresetsLIBFFI_CFLAGSandLIBFFI_LIBSfrom the SDK before the pkg-configcheck, so values passed on the command line are ignored.
Doc/using/configure.rstdocuments bothas overrides. This uses the same preserve-if-set form as the pkg-config fallback and the libuuid
probe.
Configuring with
LIBFFI_CFLAGS=-I/nonexistent/include/ffi LIBFFI_LIBS="-L/nonexistent/lib -lffi",the Makefile currently ends up with the SDK paths:
and with this change keeps the given values:
With no overrides the output is unchanged.
USING_APPLE_OS_LIBFFIdrops out when overridingsince it guards Apple-libffi code in
_ctypes. iOS sets a differentac_sys_systemand isunaffected. The other documented
*_CFLAGS/*_LIBSpairs already preserve user values.