Skip to content

gh-95555: Fix a stale comment about negating \P in a character class #156490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fedonman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-95555: Fix a stale comment about negating \P in a character class #156490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,8 +1010,8 @@ def test_property_escapes(self):
with self.subTest(char=c):
self.assertEqual(bool(ci.fullmatch(c)), expect)
self.assertTrue(re.fullmatch(r'\p{Alphabetic=No}+', '123 '))
# These are engine categories, so (unlike \P of a multi-range
# property) they can be negated inside a character class.
# These are engine categories, so a negated one joins the set directly
# as a CATEGORY rather than being alternated in as a separate branch.
self.assertTrue(re.fullmatch(r'[\P{Alphabetic}]+', '123 .'))
self.assertTrue(re.fullmatch(r'[\p{XID_Start}_]+', 'foo_bar'))

Expand Down
Loading