Repository navigation
gh-158942: Use more unique variable names in Py_MIN/MAX/ABS() - #158969
Merged
Merged
Conversation
If Py_MIN/MAX/ABS() macros are called on an existing "_x" or "_y" variable name, the macro local variables may be overriden by the external variables. So use more unique names in the macros. Add test_min_max_abs_macros() to _testlimitedcapi.
Member
Author
Contributor
|
If the other compatibility changes are considered acceptable, I have no objection to this change. For reference, I also used an LLM to scan 1,561 PyPI packages with C extensions and found only one case of nested Py_MIN() usage, in librt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Py_MIN/MAX/ABS() macros are called on an existing "_x" or "_y" variable name, the macro local variables may be overriden by the external variables. So use more unique names in the macros.
Add test_min_max_abs_macros() to _testlimitedcapi.
Py_MIN(),Py_MAX()andPy_ABS()cause C compatibility regressions #158942