Repository navigation
gh-158986: Fix profiling.sampling module type for nested site-packages - #158993
Open
sricursion wants to merge 1 commit into
Open
sricursion wants to merge 1 commit into
sricursion wants to merge 1 commit into
Conversation
…ackages extract_module_name() checked the stdlib directory first, so files in a site-packages directory inside it were reported as stdlib modules. Use the most specific matching directory instead.
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_module_name()checked the stdlib directory before the site-packages directories. In a regular installationsite-packagesis inside the stdlib directory, so files in it were reported as stdlib modules namedsite-packages.<module>. The heatmap index then listed them under "Standard Library" and flamegraph labels carried thesite-packages.prefix. The fix collects the stdlib and site-packages directories that contain the file and uses the one with the most path components, so a stdlib file still wins over a broader entry such assys.prefix(whichsite.getsitepackages()also returns on Windows), and stdlib wins a tie. The classification dates from the heatmap collector (gh-140677) and was moved tomodule_utilsin gh-142927.