Skip to content

gh-159739: [typing] Handle generic alias construction errors - #159772

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
jelle-openai:jelle/codex/gh-159739-generic-alias-errors
Oct 20, 2026
Merged

gh-159739: [typing] Handle generic alias construction errors#159772
JelleZijlstra merged 1 commit into
python:mainfrom
jelle-openai:jelle/codex/gh-159739-generic-alias-errors

Conversation

@jelle-openai

@jelle-openai jelle-openai commented Oct 19, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@JelleZijlstra
pythongh-159739: Handle generic alias construction errors
3304449 
Backport to 3.15 and 3.14 (Objects/typevarobject.c only on 3.14).
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
Open
@JelleZijlstra JelleZijlstra added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 19, 2026
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) October 20, 2026 17:19
@JelleZijlstra
JelleZijlstra merged commit 07df106 into python:main Oct 20, 2026
62 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Sorry, @jelle-openai and @JelleZijlstra, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 07df106f7efa7e5e3f5fba4b4927eaba5bcd98d0 3.14

@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159909 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@jelle-openai jelle-openai mentioned this pull request Oct 20, 2026
Merged
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159929 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
JelleZijlstra added a commit that referenced this pull request Oct 20, 2026
@miss-islington @jelle-openai @JelleZijlstra
[3.15] gh-159739: [typing] Handle generic alias construction errors (G…
429ed98 
…H-159772) (#159909)

(cherry picked from commit 07df106)

Co-authored-by: Jelle Zijlstra <jelle@openai.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra pushed a commit that referenced this pull request Oct 20, 2026
@jelle-openai
[3.14] gh-159739: [typing] Handle generic alias construction errors (G…
7615f71 
…H-159772) (#159929)

Backport the typevarobject.c fix; Python 3.14 does not decref subargs on the generic-alias substitution error path.

(cherry picked from commit 07df106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jelle-openai @JelleZijlstra