Skip to content

Conversation

@cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Dec 3, 2025

No description provided.

@cdce8p cdce8p marked this pull request as draft December 3, 2025 01:13
@cdce8p
Copy link
Collaborator Author

cdce8p commented Dec 3, 2025

This is blocked by (at least) hauntsaninja/mypy_primer#227 and updates to the materialize requirements upstream.

@hauntsaninja Installing all the materialize requirements seems a bit much to me. Does it make sense to reduce that list / only install selected once during the primer run?
https://github.com/MaterializeInc/materialize/blob/main/ci/builder/requirements.txt
https://github.com/hauntsaninja/mypy_primer/blob/70790160c6ad55c88c56fb8779b6b46bc75a4ece/mypy_primer/projects.py#L1281-L1287

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p cdce8p marked this pull request as ready for review December 5, 2025 18:05
@JelleZijlstra JelleZijlstra merged commit 9c3ed87 into python:master Dec 5, 2025
22 checks passed
@cdce8p cdce8p deleted the primer-314 branch December 5, 2025 21:19
@github-project-automation github-project-automation bot moved this from Todo to Done in GC-Content-Calculator Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants