Fix narrowing for AbstractSet and Mapping#21352
Open
hauntsaninja wants to merge 5 commits intopython:masterfrom
Open
Fix narrowing for AbstractSet and Mapping#21352hauntsaninja wants to merge 5 commits intopython:masterfrom
hauntsaninja wants to merge 5 commits intopython:masterfrom
Conversation
This builds on the tech I added a few days ago in python#21281
hauntsaninja
force-pushed
the
mypynarrow
branch
from
b29ab7b to
e703388
Compare
hauntsaninja
force-pushed
the
mypynarrow
branch
from
7f4c740 to
89bf6df
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: xarray (https://github.com/pydata/xarray)
- xarray/tests/test_dataarray.py:291: error: Unused "type: ignore" comment [unused-ignore]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the tech I added a few days ago in #21281. So we can also get rid of frozenset special case from #21151. I believe we account for all the dangerous_comparison logic now