Repository navigation
python-xlib: Fixes from Avasam/python-xlib#7 - #16670
Merged
Merged
Conversation
- `rq.List` accepts `rq.Str`, a `ValueField` instance, or any parse-only type with a `parse_binary` method (like `Xlib.ext.xinput.ClassInfo`) as its type. `rq.FixedList` accepts the same types. - Value fields accept `None` as their name. `rq.Field.name` is `str | None` to match the runtime class default, so the `*.name` stubtest allowlist entry is no longer needed. - `rq.Object` accepts a tuple, dict or `DictWrapper` as its default, and `rq.Object.default` has the same type. - `rq.Str.pack_value` accepts `bytes`. - `rq.Struct.fields` is a tuple of any length instead of a single field.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes noticed by Claude Opus 5.5 whilst working on Avasam/python-xlib#7 that apply to
types-python-xlib.rq.Listacceptsrq.Str, aValueFieldinstance, or any parse-only type with aparse_binarymethod (likeXlib.ext.xinput.ClassInfo) as its type.rq.FixedListaccepts the same typesNoneas their name.rq.Field.nameisstr | Noneto match the runtime class default, so the*.namestubtest allowlist entry is no longer neededrq.Objectaccepts a tuple, dict orDictWrapperas its default, andrq.Object.defaulthas the same typerq.Str.pack_valueacceptsbytesrq.Struct.fieldsis a variable-length tuple, not single