Repository navigation
Add default GPL license if not specified in the program - #110
Merged
Merged
Conversation
Without a LICENSE, @llvm.compiler.used still named one, and opt stopped on "use of undefined value @license". A program with no LICENSE now gets "GPL", the kernel's own license, and a warning that says so; an explicit LICENSE is emitted as written. The old failing license test becomes passing_tests/license_default.py: it calls print, which lowers to the GPL-only bpf_trace_printk, so the verifier accepts it only if the default reaches the kernel. license_non_gpl.py is the counterpart, a verifier-level negative fixture pinned to the kernel's GPL rejection, and test_license_ir.py checks both license sections and the warning. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Remaining user-guide documentation still incorrectly states that an explicit license is required.
1 open finding
What changed in this PR
Adds automatic GPL licensing for programs without an explicit LICENSE.
Changes:
- Emits a default
"GPL"license and warning. - Adds IR and verifier coverage.
- Updates license documentation and fixtures.
| File | Description |
|---|---|
pythonbpf/license_pass.py |
Implements default license emission. |
tests/test_license_ir.py |
Tests explicit and default license IR. |
tests/test_config.toml |
Configures non-GPL verifier failure. |
tests/passing_tests/license_default.py |
Adds default-GPL fixture. |
tests/failing_tests/license.py |
Removes obsolete fixture. |
tests/failing_tests/license_non_gpl.py |
Adds non-GPL rejection fixture. |
docs/user-guide/decorators.md |
Documents default licensing. |
docs/getting-started/quickstart.md |
Updates introductory guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+296
to
+297
| If a program defines no `LICENSE`, PythonBPF uses `"GPL"`, the kernel's own | ||
| license, and logs a warning: |
The overview example still labelled the LICENSE declaration as required, which contradicts the GPL default documented in decorators.md and the quickstart. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.