Add missing runner_lib dep to main_static#19210
Conversation
Summary: D82497138 added new transitive includes (`constants.h`, `multimodal_prefiller.h`, `extension/tensor/tensor.h`) into `executorch/extension/llm/runner/util.h`. The llava `main.cpp` already includes `multimodal_runner.h`, `multimodal_input.h`, and `image.h`, and calls `create_multimodal_runner` and `load_tokenizer` from `llm_runner_helper`, but the `main` (and auto-generated `main_static`) target only declared `print_evalue` and `threadpool` deps. After D82497138 the compile fails with `Action failed: ... (cxx_compile main.cpp) Remote command returned non-zero exit code 1` because the `runner_lib` headers cannot be found. Add `//executorch/extension/llm/runner:runner_lib` (which transitively re-exports `multimodal_runner_lib` and provides `llm_runner_helper`) to the deps of the `main` cxx_binary so the static variant resolves all required headers and symbols. Also wire the existing `seq_len` flag into `GenerationConfig::seq_len` (it was previously read from gflags but never used, which trips `-Werror=unused-variable` once the headers compile). Differential Revision: D103028501
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19210
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 Cancelled JobsAs of commit c5fc11b with merge base d8da621 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103028501. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
2 participants
Summary:
D82497138 added new transitive includes (
constants.h,multimodal_prefiller.h,extension/tensor/tensor.h) intoexecutorch/extension/llm/runner/util.h. The llavamain.cppalready includesmultimodal_runner.h,multimodal_input.h, andimage.h, and callscreate_multimodal_runnerandload_tokenizerfromllm_runner_helper, but themain(and auto-generatedmain_static) target only declaredprint_evalueandthreadpooldeps. After D82497138 the compile fails withAction failed: ... (cxx_compile main.cpp) Remote command returned non-zero exit code 1because therunner_libheaders cannot be found.Add
//executorch/extension/llm/runner:runner_lib(which transitively re-exportsmultimodal_runner_liband providesllm_runner_helper) to the deps of themaincxx_binary so the static variant resolves all required headers and symbols. Also wire the existingseq_lenflag intoGenerationConfig::seq_len(it was previously read from gflags but never used, which trips-Werror=unused-variableonce the headers compile).Differential Revision: D103028501