Bump tokenizers submodule to fix sentencepiece GCC 15 build#20135
Merged
Conversation
Updates extension/llm/tokenizers to include meta-pytorch/tokenizers#193, which bumps the sentencepiece submodule to pick up a missing `#include <cstdint>` (google/sentencepiece#1109). Without this, `pytorch_tokenizers` fails to compile inside the `executorch-ubuntu-26.04-gcc15` docker image, blocking the RISC-V baremetal CI (pytorch#19917). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20135
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unclassified FailureAs of commit bc3e7cd with merge base ac3003e ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
The tokenizers submodule bump (meta-pytorch/tokenizers#193) changed CMAKE_CXX_STANDARD from 17 to 20. Under C++20 the u8"▁" literal is const char8_t[], which has no implicit conversion to const char* and breaks std::string::rfind. Spell the SentencePiece word-boundary marker as raw UTF-8 bytes, matching the fix already on the 1.3 release branch (pytorch#19824). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kirklandsign
approved these changes
Jun 9, 2026
Contributor
Author
|
Failures unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates extension/llm/tokenizers to include
meta-pytorch/tokenizers#193, which bumps the sentencepiece submodule to pick up a missing
#include <cstdint>(google/sentencepiece#1109).Without this,
pytorch_tokenizersfails to compile inside theexecutorch-ubuntu-26.04-gcc15docker image, blocking the RISC-V baremetal CI (#19917).Test plan
CI