Skip to content

Log file_bytes in save_packed_index for orphan accumulation visibility (#20246) #20246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Jun 16, 2026
+9 −2
Merged

Log file_bytes in save_packed_index for orphan accumulation visibility (#20246) #20246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions backends/xnnpack/runtime/XNNWeightsCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,11 +574,18 @@ Error XNNWeightsCache::save_packed_index() {
ET_LOG(Error, "fsync of packed cache failed (errno=%d)", errno);
// Continue — data is in page cache; durability is best-effort.
}
// Log the final file size (= index_start + trailer) so production
// logs surface unbounded growth from orphan packs: a same-name
// re-pack leaves the old packed bytes in the file even though the
// trailer drops the old entry. Monitoring file_bytes over time tells
// us when GC or a size cap is needed.
const size_t file_bytes = index_start + buf.size();
ET_LOG(
Info,
"Saved packed weight index: %u entries at offset %zu",
"Saved packed weight index: %u entries at offset %zu, file_bytes=%zu",
entry_count,
index_start);
index_start,
file_bytes);

// Promote freshly-packed entries to from_load now that they're durable
// on disk, so delete_packed_data preserves them across unload/reload.
Expand Down
Loading