Skip to content

Flip executorch android extension to source-only ABI (#23931) - #23931

Open
rybalkinsd wants to merge 1 commit into
pytorch:mainfrom
rybalkinsd:export-D125602727
Open

rybalkinsd wants to merge 1 commit into
pytorch:mainfrom
rybalkinsd:export-D125602727

Conversation

@rybalkinsd

@rybalkinsd rybalkinsd commented Oct 16, 2026 •

Copy link
Copy Markdown

Summary:

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727

Copilot AI balanced review requested due to automatic review settings October 16, 2026 16:57
@pytorch-bot

pytorch-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23931

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 11 Awaiting Approval

As of commit 5f7039b with merge base 185668b (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2026
@meta-codesync

meta-codesync Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@rybalkinsd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125602727.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: rybalkinsd / name: Sergei Rybalkin (d64fe30)

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped change has no identified blockers, with reported ABI equivalence and consumer-failure isolation checks.

0 open findings

What changed in this PR

Switches ExecuTorch’s two Android library targets to source-only ABI generation.

Changes:

  • Sets abi_generation_mode = "source_only" for executorch and executorch_llama.
File Description
extension/​android/​BUCK Enables source-only ABI generation for both Android targets.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@meta-codesync meta-codesync Bot changed the title Flip executorch android extension to source-only ABI Flip executorch android extension to source-only ABI (#23931) Oct 16, 2026
Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:11
rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 16, 2026
Summary:

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped configuration changes have no identified issues, and reported validation shows ABI compatibility with the consumer failure confirmed as pre-existing.

0 open findings

🧠 Review effort: Balanced

rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 16, 2026
Summary:

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727
Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped changes have reported ABI parity and consumer validation, with no blocking issues identified.

0 open findings

🧠 Review effort: Balanced

rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 16, 2026
Summary:
Pull Request resolved: pytorch#23931

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727
@psiddh

psiddh commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@rybalkinsd Can you complete EasyCLA please

Copilot AI balanced review requested due to automatic review settings October 18, 2026 16:13
rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 18, 2026
Summary:

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved findings remain, and reported ABI comparisons and consumer checks support this narrowly scoped configuration change.

No open issues 🎉

Review effort: Balanced

rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 18, 2026
Summary:
Pull Request resolved: pytorch#23931

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727
rybalkinsd added a commit to rybalkinsd/executorch that referenced this pull request Oct 21, 2026
Summary:
Pull Request resolved: pytorch#23931

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727
Summary:

Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.

Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.

Reviewed By: siaojiecai

Differential Revision: D125602727
Copilot AI balanced review requested due to automatic review settings October 24, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The two narrowly scoped configuration changes have no identified defects and are supported by reported ABI-equivalence and consumer regression checks.

No open issues 🎉

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants