Repository navigation
Flip executorch android extension to source-only ABI (#23931) - #23931
rybalkinsd wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23931
Note: Links to docs will display an error until the docs builds have been completed.
|
|
@rybalkinsd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125602727. |
|
|
This PR needs a
|
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped change has no identified blockers, with reported ABI equivalence and consumer-failure isolation checks.
0 open findings
What changed in this PR
Switches ExecuTorch’s two Android library targets to source-only ABI generation.
Changes:
- Sets
abi_generation_mode = "source_only"forexecutorchandexecutorch_llama.
| File | Description |
|---|---|
extension/android/BUCK |
Enables source-only ABI generation for both Android targets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary: Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
17689e5 to
dd97f37
Compare
Summary: Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
dd97f37 to
a0db88a
Compare
Summary: Pull Request resolved: pytorch#23931 Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
a0db88a to
d64fe30
Compare
|
@rybalkinsd Can you complete EasyCLA please |
d64fe30 to
dc3d020
Compare
Summary: Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
Summary: Pull Request resolved: pytorch#23931 Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
dc3d020 to
f552a40
Compare
Summary: Pull Request resolved: pytorch#23931 Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
b2758ef to
78b98a8
Compare
Summary: Flips 2 targets in xplat/executorch/extension/android to abi_generation_mode = "source_only" (clean flip, comparator 0 on both). Causation check: the single consumer-build failure (etu2net_debug, missing aiplatform inference segmentation interface on the stub classpath) reproduces identically with the flip reverted, so it is a pre-existing gap unrelated to this change, not a regression. Validation per target: buck2 build of default, class-abi and source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent; widened six-leg compareAbi reports 0 differences; KmDump shows 0 public member diffs; direct consumers build 239/241 with the sole failure proven pre-existing as above. Reviewed By: siaojiecai Differential Revision: D125602727
78b98a8 to
5f7039b
Compare
Summary:
Flips 2 targets in xplat/executorch/extension/android to
abi_generation_mode = "source_only" (clean flip, comparator 0 on
both). Causation check: the single consumer-build failure
(etu2net_debug, missing aiplatform inference segmentation interface on
the stub classpath) reproduces identically with the flip reverted, so
it is a pre-existing gap unrelated to this change, not a regression.
Validation per target: buck2 build of default, class-abi and
source-only-abi variants green; KOSABI_APPLICABILITY_REPORT_V2 silent;
widened six-leg compareAbi reports 0 differences; KmDump shows 0
public member diffs; direct consumers build 239/241 with the sole
failure proven pre-existing as above.
Reviewed By: siaojiecai
Differential Revision: D125602727