Repository navigation
Conversation
The Cortex-M size test job only builds size_test and checks its size, so a build that links but does not run would still pass. Let run_fvp.sh run a cortex-m ELF directly when no --bundle is given, and add test_minimal_classic_ml_cortex_m55, which embeds a small add model in the minimal_classic_ml runner and runs it on Corstone-300. The bare_metal leg of the size test job now runs it after the size check. Fixes pytorch#12812
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24131
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 14 Unrelated FailuresAs of commit bc10c9c with merge base ea34866 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Dox45! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
|
|
|
@pytorchbot label "release notes: none" |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The Cortex-M size test job only builds size_test and checks its size, so a build that links but does not run would still pass.
Following the suggestion on the issue, this uses the minimal_classic_ml example instead of executor_runner and runs without BundleIO:
Tested locally: the runner boots and completes inference on Corstone-300 (exit 0), an invalid ELF fails as expected, and test_run_fvp.py passes.
Fixes #12812
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani @nil-is-all