Add event tracing and ETDumps to executor_runner#4502
Add event tracing and ETDumps to executor_runner#4502facebook-github-bot merged 2 commits intopytorch:mainfrom
Conversation
benkli01
commented
Aug 1, 2024
- Enabled via EXECUTORCH_ENABLE_EVENT_TRACER
- Add flag 'etdump_path' to specify the file path for the ETDump file
- Add flag 'num_executions' for number of iterations to run
- Create and pass event tracer 'ETDumpGen'
- Save ETDump to disk
- Update docs to reflect the changes
- Enabled via EXECUTORCH_ENABLE_EVENT_TRACER - Add flag 'etdump_path' to specify the file path for the ETDump file - Add flag 'num_executions' for number of iterations to run - Create and pass event tracer 'ETDumpGen' - Save ETDump to disk - Update docs to reflect the changes Signed-off-by: Benjamin Klimczak <benjamin.klimczak@arm.com> Change-Id: I876d5138455d1b04fba9af4016d8341e8866f9c0
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4502
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 50b711e with merge base 6c69ebd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Didn't find following labels among repository labels: partner:arm |
|
@pytorchbot label 'partner: arm' |
|
The failing test looks unrelated to my changes. |
digantdesai
left a comment
There was a problem hiding this comment.
Looks good to me. Left some comments. I assume you tried running this with both portable and XNNPACK, with and without this flag and it works OK?
Do you want to add a test with this flag enabled just so we can catch any build issues in this part of the logic?
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
- Make flag 'num_executions' available in the executor_runner irrespective of the event tracing - Update docs to explain usage of 'ENABLE_XNNPACK_PROFILING' for additional profiling info Signed-off-by: Benjamin Klimczak <benjamin.klimczak@arm.com> Change-Id: I35abbd2d913880cb129bddb80514992f4dd84004
|
Thanks for the review @digantdesai ! I pushed a patch with some changes.
Yes, I didn't see any problems.
Sure. Where would you add this test? I haven't found an obvious place. |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: D61211201 Pull Request resolved: pytorch#4502
|
Hey @benkli01, I ended up needing to back out this change due to it breaking the test-llama-runner-qnn-linux job (see https://github.com/pytorch/executorch/actions/runs/10398365231/job/28795542762). I apologize for the inconvenience, it didn't get caught on the PR. I'm happy to help re-land this, as this is a change that we want to keep. Thanks. |
|
cc @cccclai |
This PR needs a
|
|
Re-opened with #5027 as this change was reverted. |