Modernize target_link_libraries in Cmakelists.txt#1283
Closed
moksiuc wants to merge 3 commits intopytorch:mainfrom
Closed
Modernize target_link_libraries in Cmakelists.txt#1283moksiuc wants to merge 3 commits intopytorch:mainfrom
moksiuc wants to merge 3 commits intopytorch:mainfrom
Conversation
Provide linking mode explicitely: target_link_libraries(my_target PUBLIC A) target_link_libraries(my_target PRIVATE B) target_link_libraries(my_target INTERFACE C)
Contributor
Author
|
@jiannanWang has imported this pull request. If you are a Meta employee, you can view this in D99889875. |
|
@jiannanWang merged this pull request in 2b26470. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide linking mode explicitely:
target_link_libraries(my_target PUBLIC A)
target_link_libraries(my_target PRIVATE B)
target_link_libraries(my_target INTERFACE C)