Fix dropdown width and add MyST directives test page#251
Merged
Conversation
✅ Deploy Preview for pytorchsphinxtheme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{dropdown}directives rendering at only 30% page width instead of full article widthtest-myst-directives.md) covering all common MyST and sphinx-designdirectives
The issue
.sd-cardin_sphinx_design.scsssetswidth: 30%andmax-width: 500pxfor card grid layouts. Sphinx-design renders dropdowns as.sd-card.sd-dropdown, so dropdowns inherited these card width constraints and appeared as a narrow strip instead of spanning the full content area. See here - scroll down to dropdown.The Fix
Added
.sd-card.sd-dropdownoverrides in_sphinx_design.scssthat setwidth: 100%andmax-width: 100%, and disable the card hover underline animation on dropdowns. The selector is specific to elements with both classes, so regular cards in grids are unaffected.Test plan
npx grunt defaultcd docs && python3 -m sphinx -b html . _build/htmltest-myst-directives.htmltest-cards.htmlare unchanged (still 30% width in grids)