You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Initialize target updaters from an unlocked shallow source container, allowing list-backed functional parameters to be structurally selected. Extend the existing SAC list-critic regression through a real SoftUpdate.step().
Validation
Tested on an H100 80 GB host with PyTorch 2.11.0+cu130.
Upstream reproduction fails in SoftUpdate(...) with RuntimeError: Cannot modify locked TensorDict.
Patched reproduction moves both delayed critic leaves by exactly 0.5 after adding 1 to each source.
Targeted updater/SAC tests: 12 passed, 196 deselected in 1.98 s.
Full SAC suite: 1679 passed, 494 skipped in 27.16 s.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
meta-claBot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 9, 2026
Reviewed rebased head ab1bdf76ebf7577ee29fb4a8cba79f7ee7a82fc5 against current origin/main and the latest bot/check state. I checked that the shallow clone unlocks only the temporary TensorDict container needed by select, while preserving the underlying parameter objects and source/target mapping; the extended regression also exercises a real SoftUpdate.step() for both SAC versions.
Targeted result: pytest -q test/objectives/test_sac.py::TestSAC::test_sac_list_qvalue_networks -> 2 passed. I did not find a functional issue in this diff. Residual risk is the broader suite, which is still awaiting workflow approval on this fork PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugFixCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Objectives
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4076
Initialize target updaters from an unlocked shallow source container, allowing list-backed functional parameters to be structurally selected. Extend the existing SAC list-critic regression through a real
SoftUpdate.step().Validation
Tested on an H100 80 GB host with PyTorch 2.11.0+cu130.
SoftUpdate(...)withRuntimeError: Cannot modify locked TensorDict.0.5after adding1to each source.12 passed, 196 deselectedin 1.98 s.1679 passed, 494 skippedin 27.16 s.cc @vmoens