You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add one focused test file covering pooled target truncation, paper-normalized quantile-Huber loss and gradients, arbitrary batch ranks, nested keys, terminal-NaN masking, priority output, and invalid truncation counts.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
meta-claBot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 9, 2026
Reviewed rebased head 009335216aaa16e7dce87bdabdea293f4687dd5b and the current bot/check state.
This PR is not currently self-contained on its declared main base: collecting the only changed file fails with ModuleNotFoundError: No module named torchrl.objectives.tqc, and torchrl/objectives/tqc.py is absent from both this head and freshly fetched origin/main. Since this is labeled 3/3, please either stack/change the base onto the PR that introduces TQC or wait for that dependency to land and rebase; otherwise CI cannot exercise any of these numerical contracts. The new test file should also include the repository-required if __name__ == "__main__": pytest.main(...) block.
Command checked: pytest -q test/objectives/test_tqc.py (collection error above). The numerical coverage itself is well targeted once the production dependency is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add one focused test file covering pooled target truncation, paper-normalized quantile-Huber loss and gradients, arbitrary batch ranks, nested keys, terminal-NaN masking, priority output, and invalid truncation counts.
cc @vmoens