Skip to content

[Test] [TQC] [3/3] Add TQC numerical contracts test - #4079

Open
gtnv wants to merge 1 commit into
pytorch:mainfrom
gtnv:test/TQC-test
Open

[Test] [TQC] [3/3] Add TQC numerical contracts test#4079
gtnv wants to merge 1 commit into
pytorch:mainfrom
gtnv:test/TQC-test

Conversation

@gtnv

@gtnv gtnv commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Add one focused test file covering pooled target truncation, paper-normalized quantile-Huber loss and gradients, arbitrary batch ranks, nested keys, terminal-NaN masking, priority output, and invalid truncation counts.

cc @vmoens

@pytorch-bot

pytorch-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4079

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 15 Awaiting Approval

As of commit 0093352 with merge base d7659c7 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2026
@github-actions github-actions Bot added Documentation Improvements or additions to documentation Benchmarks rl/benchmark changes Objectives sota-implementations/ Tests Incomplete or broken unit tests labels Aug 9, 2026
@gtnv
gtnv marked this pull request as ready for review August 9, 2026 02:31
@gtnv gtnv changed the title [Test] [TQC] [3/3] Add TQC numerical contracts [Test] [TQC] [3/3] Add TQC numerical contracts test Aug 9, 2026
@vmoens

vmoens commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Reviewed rebased head 009335216aaa16e7dce87bdabdea293f4687dd5b and the current bot/check state.

This PR is not currently self-contained on its declared main base: collecting the only changed file fails with ModuleNotFoundError: No module named torchrl.objectives.tqc, and torchrl/objectives/tqc.py is absent from both this head and freshly fetched origin/main. Since this is labeled 3/3, please either stack/change the base onto the PR that introduces TQC or wait for that dependency to land and rebase; otherwise CI cannot exercise any of these numerical contracts. The new test file should also include the repository-required if __name__ == "__main__": pytest.main(...) block.

Command checked: pytest -q test/objectives/test_tqc.py (collection error above). The numerical coverage itself is well targeted once the production dependency is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks rl/benchmark changes CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Documentation Improvements or additions to documentation Objectives sota-implementations/ Tests Incomplete or broken unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants