Repository navigation
Fix AP242 thread PMI ownership for same-named holes - #2232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2231.
Part-level prose no longer inherits the union of geometry from multiple same-named draughting callouts. A prose thread may pair with a structured property only when its nominal size, pitch, fit class, and hand uniquely match; the structured property supplies its own face reference, which still must pass exact cylindrical topology and canonical-hole checks. Ambiguous duplicate designations remain reported rather than guessed.
Regression coverage uses two distinct M2/M4 holes with the same generic presentation name and checks Part21 projection, separate typed thread ownership, provenance, render labels, PMI lint, and bore measurement association. Existing conflicting-source tests remain intact.
Producer note: this is a conservative recovery path, not a substitute for an explicit relationship from each descriptive property to its own shape aspect/face. If two holes have identical thread designations, an explicit producer-side association is needed to pair prose without ambiguity.
Local verification: 177 focused tests passed; Ruff check and format passed.