Skip to content

Add visible-only isometric option and #2233 quotation comparison - #2234

Merged
pzfreo merged 2 commits into
mainfrom
fix/2233-quotation-sheet
Oct 7, 2026
Merged

pzfreo merged 2 commits into
mainfrom
fix/2233-quotation-sheet

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Addresses #2233 with a supported per-view hidden-line setting and a reproducible quotation-sheet comparison.

  • Add Sheet view handle hidden_lines(True/False) for principal and pictorial views, defaulting to current behavior.
  • Retain ISO while suppressing its hidden edges in the axial blind-hole section example.
  • Compare baseline, required section with hidden ISO, and required section with visible-only ISO as PDFs, PNGs, reports, and a measured-fact ledger.
  • Document source limitations: the original quotation STEP and edited sheet are unavailable, so this is a synthetic policy test, not a claim about the original connector.

Local verification: 35 view-constraint and issue tests passed; focused issue tests rerun after final edit; Ruff and diff checks passed. On the synthetic part the ISO hidden-edge count changes from 10 to 0; the visible ISO, axial section, H7 fit, measured requirements, and clean lint remain.

Generate PDFs: python docs/examples/quotation_blind_hole.py --out-dir /tmp/draftwright-2233 --date 2026-10-07 --sheet 1/1

@pzfreo
pzfreo enabled auto-merge (squash) October 7, 2026 17:49
@pzfreo
pzfreo merged commit 4dfc63f into main Oct 7, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/2233-quotation-sheet branch October 7, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant