Repository navigation

fix(design): text style sets only the changed field and clamps size to the kernel range - #5773

Open

prakashUXtech wants to merge 8 commits into

devfrom

lead/text-style-TS-7b

Open

fix(design): text style sets only the changed field and clamps size to the kernel range#5773
prakashUXtech wants to merge 8 commits into
devfrom
lead/text-style-TS-7b

prakashUXtech commented Oct 26, 2026

Contributor

This fixes Packet-Review 2's amendments 7 and 8 (#3779) in Design's kernel route for text styles.

With a mixed selection, a text style command now sets only the field the user changed. Each layer keeps its own value for every other field. Before, the first layer's whole style overwrote the rest.
Text size clamps to the kernel's range, TextStyleRules.range(.size) (1...1600), instead of a local 1...1000. The rows, the kernel and Design now agree on the limit. The DesignModel.LiveStyling size-clamp mutation now points at the new line.

Tests: DesignTextStyleTests.aMixedSelectionTakesOnlyTheChangedField changes the size on two layers with different families. Both take 1500, which the kernel range keeps, and each keeps its own family. A size over the range clamps to 1600. DesignStyleTests now expects the kernel's 1600 ceiling.

Stacked on #5047 (TS-7). It gets the fast-lane label when it is retargeted to dev.

Belt-Lead: act-1a1774f754d-5cse
Feature: text-style
Slice: TS-design
Refs #3779
Mutate: DesignModel.DesignTextStyle+Kernel 4/4
Fast-Check: pass
Head: e27cfff

Generated by Claude Code

prakashUXtech added 8 commits

October 24, 2026 05:45


          test(design): DesignTextStyleTests for the kernel's text style on tex…

c5fc1fc

…t layers (TS-7)


          feat(design): text layers take italic, line height and tracking throu…

37aa684

…gh the kernel's text style (TS-7)


          test(design): repoint the fixedWidth decode mutation at its new file …

d6b3051

…(TS-7)


          test(design): the CLI's design list-commands golden lists the seven t…

a05c0e2

…ext commands (TS-7)


          Merge remote-tracking branch 'origin/dev' into wt-ts7

ca7832f

# Conflicts:
#	Sources/DesignModel/DesignCommandCatalog.swift
#	Tests/AfterGlowCLITests/Golden/apps/design.list-commands.json
#	Tests/DesignModelTests/DesignCommandCatalogTests.swift
#	Tests/command-ids/design.txt


          test(design): a mixed text selection takes only the changed field, si…

80feb62

…zes keep the kernel's 1...1600


          fix(design): text style commands set only the changed field and clamp…

53de965

… size to the kernel's range


          test(design): repoint the size clamp mutation at the kernel's range

e27cfff

prakashUXtech added the fast-lane label

— with

Claude

prakashUXtech added the beta label

github-actions Bot commented Oct 26, 2026

Contributor

Fast lane: this PR body has AI attribution lines ("Generated by Claude Code", "🤖 Generated with" or a Co-Authored-By: Claude trailer). The lane strips them from the squash commit, so nothing waits on this, but please delete them from the body and leave them out of your next PRs.

prakashUXtech mentioned this pull request

Feature: text-style #3779

Open

prakashUXtech changed the base branch from lead/text-style-TS-7 to dev

October 31, 2026 05:38

github-actions Bot removed the fast-lane label

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: not eligible. too big: 427 lines, 16 files (max 400 lines, 15 files). This PR now needs normal captain review.

github-actions Bot added the fast-lane label

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot added fast-lane and removed fast-lane labels

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot added fast-lane and removed fast-lane labels

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot added fast-lane and removed fast-lane labels

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot added fast-lane and removed fast-lane labels

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot removed the fast-lane label

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

29 similar comments

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Oct 31, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

github-actions Bot commented Nov 1, 2026

Contributor

Fast lane: labelled because the PR carries Belt-Lead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta needs-split