Skip to content

fix(tone): document HSL units and range policy, pin hue/sat and hsl with hand values - #596

Merged
github-actions[bot] merged 1 commit into
devfrom
lead/tone-pack-r1-b1
Oct 19, 2026
Merged

github-actions[bot] merged 1 commit into
devfrom
lead/tone-pack-r1-b1

Conversation

@prakashUXtech

@prakashUXtech prakashUXtech commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Anatomy round 1, batch r1-b1 for tone-pack (ColorAdjust). Part of #432.

What each fix is, and the test that proves it:

  1. HSLShift hue unit. HSLShift's doc and the first sentence of hsl(_:)'s doc now say hue is percent of a ±30° turn (100 = +30°), not degrees as in hueSaturation. The field keeps its name because it is a W1 shared value type. Test: ColorAdjustTests.hslHueIsPercentOfThirtyDegrees (reds hue 100 on pure red equals hueSaturation(hue: 30) within 1e-5).
  2. Out-of-range policy documented. The vibrance and hueSaturation docs say they throw RasterError.invalid for a non-finite or out-of-range value. The hsl doc says out-of-range values are clamped. Test: ColorAdjustTests.outOfRangePolicyIsDocumented.
  3. hsl non-finite error names its band. The eight shifts are zipped with their band names, so the message reads like hsl blues hue nan: must be finite. Test: ColorAdjustTests.nanThrows (the blues NaN message contains "blues").
  4. hueSaturation contract. This follows the lead decision. The packet now describes hueSaturation as the standard HSL rotate/scale/blend as built, and pixel parity with the app's existing op is checked when the app adopts it (W3). The TP-3 acceptance line names the test as a reference check. The test is renamed hueSaturationMatchesHSLReference. A new hueSaturationHandValues test checks six hand-computed pixels (red hue +120 gives green, red hue -60 gives magenta, mid grey is unchanged by hue, saturation -100 on red gives grey 0.5, lightness ±50 on red gives (1, .5, .5) and (.5, 0, 0)). Those values do not come from the implementation.
  5. rangeWeightsSumToOne can now see sums above 1. Every range is set to lightness -50, which is not clamped, so each saturated pixel must equal the single-shift hueSaturation(lightness: -50) result and each grey must be unchanged. The existing "cosine over one neighbour" mutant is still caught.
  6. hsl hue scale, range lightness and grey guard. New test: ColorAdjustTests.rangeHueAndLightness. Reds hue 100 turns pure red to hue 30, reds lightness 50 takes pure red to L 0.75, and mid grey is unchanged. New mutation entries cover the ×0.3 factor, the dropped lightness and the removed grey guard.
  7. vibrance negative branch and gamut cap. New test: ColorAdjustTests.vibranceNegativeAndCapped. On seeded opaque pixels, vibrance(-100) gives r == g == b == luma within 1e-6, and vibrance(100) keeps every straight channel in 0...1. New mutation entries cover the flipped negative branch and the removed cap line.

Gate: scripts/ci prints CI: PASS on this head after rebasing on origin/dev. scripts/mutate --run --changed-since origin/dev caught 13/13, including 8/8 for CoreRaster.ColorAdjust.

Docs MCP tools: not needed. This change uses only stdlib arithmetic and Swift Testing APIs that the suite already uses.

Belt-Lead: act-1a150bfbcf7-sfwy
Feature: tone-pack
Slice: TP-a, TP-mix
Mutate: 8/8 CoreRaster.ColorAdjust
Fast-Check: pass
Head: be8e9e5


@prakashUXtech prakashUXtech added the fast-lane Small green PR, auto-merge when eligible label Oct 19, 2026 — with Claude
@github-actions
github-actions Bot merged commit 5e7515c into dev Oct 19, 2026
1 check passed
@github-actions github-actions Bot added the fast-lane-merged Merged by the fast lane; review after the fact label Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast lane: merged into dev (168 lines, 5 files, Fast-Check marker).

prakashUXtech added a commit that referenced this pull request Oct 19, 2026
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
prakashUXtech added a commit to qbtrix/creative-apps that referenced this pull request Oct 19, 2026
…rallel (#3126)

Moves the creative-core pin from bf5426e to 0de5687, the head of core
`main` (green, promoted from dev). The range has the resident-rendering
speedups from qbtrix/creative-core#620: the batched composite commits
without waiting, the resident dirty check is storage identity instead of
a pixel compare, and the Float16 tile upload vectorizes. It also has
qbtrix/creative-core#626, which repoints the mutation anchor #620 moved.

Core range (58 commits):
qbtrix/creative-core@bf5426e...0de5687

Core PRs in the range: qbtrix/creative-core#567 qbtrix/creative-core#568
qbtrix/creative-core#569 qbtrix/creative-core#570
qbtrix/creative-core#571 qbtrix/creative-core#573
qbtrix/creative-core#574 qbtrix/creative-core#575
qbtrix/creative-core#576 qbtrix/creative-core#577
qbtrix/creative-core#578 qbtrix/creative-core#579
qbtrix/creative-core#580 qbtrix/creative-core#581
qbtrix/creative-core#582 qbtrix/creative-core#583
qbtrix/creative-core#584 qbtrix/creative-core#585
qbtrix/creative-core#586 qbtrix/creative-core#587
qbtrix/creative-core#588 qbtrix/creative-core#589
qbtrix/creative-core#590 qbtrix/creative-core#591
qbtrix/creative-core#592 qbtrix/creative-core#593
qbtrix/creative-core#594 qbtrix/creative-core#595
qbtrix/creative-core#596 qbtrix/creative-core#597
qbtrix/creative-core#598 qbtrix/creative-core#599
qbtrix/creative-core#600 qbtrix/creative-core#601
qbtrix/creative-core#602 qbtrix/creative-core#603
qbtrix/creative-core#605 qbtrix/creative-core#606
qbtrix/creative-core#607 qbtrix/creative-core#608
qbtrix/creative-core#609 qbtrix/creative-core#612
qbtrix/creative-core#613 qbtrix/creative-core#614
qbtrix/creative-core#615 qbtrix/creative-core#616
qbtrix/creative-core#617 qbtrix/creative-core#618
qbtrix/creative-core#619 qbtrix/creative-core#620
qbtrix/creative-core#621 qbtrix/creative-core#622
qbtrix/creative-core#623 qbtrix/creative-core#625
qbtrix/creative-core#626

Besides the pin:
- `project.yml` gets the same revision, as in #3023.
- `PhotoWorkspace.residentComposited` syncs a region's layer tiles
across the cores (through `PhotoLayerComposite.inParallel`), as the CPU
route renders its tiles. Steps keep their order. On a brush frame that
crosses two tiles the sync went from about 0.73 ms to 0.39 ms.
- `Tests/render-budgets.md` has the new 8K table and says where a
resident brush frame's time goes.

8K brush frame, release on the M2 Pro (median of three runs; the Mac was
loaded, with another Photo running): CPU 1.0 ms, GPU-resident 1.4 ms
(was 1.7). The GPU route is still behind the CPU. Most of what's left is
the display into the presenter's texture, which waits about 0.55 ms for
the GPU because the presenter draws from its own queue. Full redraw on
the resident route is 31 ms (was 35) and the first picture 166 ms (was
192).

Checked locally on macOS: `scripts/bump-core`'s steps at 0de5687. `swift
build --build-tests` passed. Every `*ModelTests` target passed except
four Library wall-clock budget tests
(`oneEditOnSixtyPhotosStaysInBudget`, `cullOneWithinBudget`,
`beginImportWithinBudget`, `orderRebuildWithinBudget`), which went over
in the parallel run on the loaded Mac and pass when run alone. The brush
perf suites (PhotoBrushDisplayTests, PhotoBrushLatencyTests,
PhotoBrushInkLatencyTests) passed. With the parallel sync on top,
`PhotoModelTests` and `PhotoRenderBackendTests` passed (647 tests), and
`PhotoRenderBudgetTests` ran in release with
`Tests/SuiteUITests/SegmentedTabsTests.swift` set aside, since it
doesn't link in release on SDK 27.
prakashUXtech added a commit that referenced this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-lane Small green PR, auto-merge when eligible fast-lane-merged Merged by the fast lane; review after the fact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant