Skip to content

Fix/model download resources - #799

Open
irulappan151204 wants to merge 3 commits into
qdrant:mainfrom
irulappan151204:fix/model-download-resources
Open

irulappan151204 wants to merge 3 commits into
qdrant:mainfrom
irulappan151204:fix/model-download-resources

Conversation

@irulappan151204

Copy link
Copy Markdown

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f608eea-71f0-4758-a395-43b9badebaa7

📥 Commits

Reviewing files that changed from the base of the PR and between d076f08 and d08a234.


📒 Files selected for processing (4)
  • ENGINEERING_REPORT.md
  • README.md
  • fastembed/common/model_management.py
  • tests/test_gcs_download.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The change updates download handling so streamed HTTP responses close on success and failure. Selected download diagnostics no longer include source URLs. New local HTTP tests check response closure, download results, failure behavior, and URL omission. The README and engineering report document the fork, setup and verification details, implemented fixes, and remaining limitations.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to d08a2

The change closes streamed model-download responses and removes source URLs from selected error messages, with tests covering both. No actionable merge risk remains.

Pre-merge checks | Passed 3 | Failed 1 | Inconclusive 1

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 2 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Inconclusive The description contains only a generic submission checklist and does not explain the resource cleanup, diagnostic changes, documentation updates, or test results. Update the description with a concise summary of the code and documentation changes, plus the tests that were added or run.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title identifies the main change: fixing resources used during model downloads. It is concise and related to the implementation.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 2 files. (2 skipped: 2 unsupported.)


  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein

joein commented Oct 10, 2026

Copy link
Copy Markdown
Member

Hey @irulappan151204

Could you please describe what this PR fixes exactly?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants