Repository navigation
Add Windows ARM64 build - #33
Merged
Merged
Conversation
joein
self-requested a review
October 5, 2026 13:56
joein
approved these changes
Oct 5, 2026
Member
|
thank you for the contribution! @ndabas |
Contributor
Author
|
Thank you for fixing the conflicts and merging! Do you have a timeline for the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says. Some notes for reviewers:
actions-rs/toolchain@v1action, because it has been archived for three years now, and the Windows runners have a Rust toolchain pre-installed anyway. We should probably remove it from the macos workflow too, let me know if you'd like me to add that to this PR as well.architecturekey fromactions/setup-pythonbecause the default is to install the native architecture anyway. Making it explicit would clutter up the matrix because this action needsx64/arm64vs.x86_64/aarch64for maturin.