Skip to content

feat(qdrant remote): validate port range#1202

Open
Goodnight77 wants to merge 1 commit into
qdrant:devfrom
Goodnight77:feat/port-validation
Open

feat(qdrant remote): validate port range#1202
Goodnight77 wants to merge 1 commit into
qdrant:devfrom
Goodnight77:feat/port-validation

Conversation

@Goodnight77
Copy link
Copy Markdown

All Submissions:

summary

Reject port/grpc_port outside 1–65535 (and bools/non-ints) in QdrantRemote class, to fail fast with a clear ValueError instead of an opaque socket error

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2026

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit f755a43
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6a000ff2286f010008c2e1d9
😎 Deploy Preview https://deploy-preview-1202--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fcf5a59f-e447-4118-a700-ed7fd39bc97a

📥 Commits

Reviewing files that changed from the base of the PR and between d72554e and f755a43.

📒 Files selected for processing (1)
  • qdrant_client/qdrant_remote.py

📝 Walkthrough

Walkthrough

QdrantRemote introduces port validation during initialization. A new private method _validate_port(value, name) enforces that port values are integers (excluding bool) within the range 1–65535, raising ValueError for invalid input. The constructor applies this validation to the optional port parameter (when provided), the grpc_port parameter unconditionally, and to any port extracted from a provided url with an explicit port component.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(qdrant remote): validate port range' clearly and directly describes the main change: adding port range validation to the QdrantRemote class.
Description check ✅ Passed The description clearly explains the purpose of the changes (rejecting invalid port values to fail fast with clear errors) and confirms testing and guideline compliance.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant