Update rust client for 1.18#278
Conversation
| } | ||
|
|
||
| impl BuilderExt for Builder { | ||
| fn configure_docs(self) -> Self { |
There was a problem hiding this comment.
The enum variant Bits1_5 in protobuf is named Bits15 in rust types.
This naming might create confusion and we can't modify the naming, without doing specially crafted file edits.
Therefore we manually add this doc comment clarifying the name and removing ambiguity.
There was a problem hiding this comment.
Is it impossible to rewrite this to Bits1_5 in our Rust client by any other means?
Because I'm still not super fond of this one:
There was a problem hiding this comment.
Neither me nor claude found a way to translate them at codegen.
Maybe there is a way to make this type private. Then we could wrap our own type around it. But this increases maintenance work so I decided to go with the comment instead.
Do you think the ambiguity justifies an extra type here?
There was a problem hiding this comment.
I see, I also am unable to change it as codegen is quite limited in terms of configuration.
We use tools/sync_proto.sh to pull proto files. We add a sed substitude to rename it to something that translates to something better. But that probably isn't worth it. Thanks for checking.
|
Please include examples for new API like those https://github.com/qdrant/rust-client/tree/dev/tests/snippet_tests |
3 participants
Updated protobufs and updated/added required builder structs.
These changes include latest TurboQuant changes from qdrant/qdrant#8914