-
Notifications
You must be signed in to change notification settings - Fork 16
Introduce Docker Compose env file #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
istride
wants to merge
253
commits into
qlands:master-2.0
Choose a base branch
from
istride:compose-env-file
base: master-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… does not have any assistants with submit privileges
The networking setup was invalid and did not allow Docker to create a network before starting up containers. This is the minimum set of changes required to get all the containers started.
Fix the networking config in the docker-compose file. Thank you, @istride, for fixing this issue
The current setup instructions require environment variables to be change in the
the Docker Compose file, but this is very error-prone. An env file is
recommended for managing environment variables.
An example file ('env.example') is provided, with default values, which should
be copied as '.env' in the same directory as the Docker Compose file, and
modified locally.
The setup instructions have been updated accordingly. First-time users are asked
to focus on the contents of the .env file and not interfere with the main Docker
Compose file. Additional instructions can be provided in the env file to give
more help about each env var.
6e6a281 to
5236e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup instructions require environment variables to be change in the the Docker Compose file, but this is very error-prone. An env file is recommended for managing environment variables.
An example file ('env.example') is provided, with default values, which should be copied as '.env' in the same directory as the Docker Compose file, and modified locally.
The setup instructions have been updated accordingly. First-time users are asked to focus on the contents of the .env file and not interfere with the main Docker Compose file. Additional instructions can be provided in the env file to give more help about each env var.