fix(cli): add feature multitenancy keeps the app's own smoke test passing - #261
Open
omercelikdev wants to merge 1 commit into
Open
omercelikdev wants to merge 1 commit into
omercelikdev wants to merge 1 commit into
Conversation
omercelikdev
force-pushed
the
fix/add-feature-multitenancy-smoke
branch
from
September 15, 2026 06:26
e433ea0 to
601e70b
Compare
…sing Tenancy is fail-closed: a request without the tenant header is refused with 400 before authentication runs. The template's smoke sends the header under UseMultiTenancy; the recipe left the smoke alone, so an app grown with the verb failed its own smoke (an authed shape expecting 401 got 400). Found by the nightly GmGrownRest shape the first time it reached its smoke. The recipe now adds the template's line after the smoke's client, with `using Goldpath;` and a Goldpath.Abstractions reference in the smoke project. A smoke that already sends the header is left alone; an engine refusal restores both files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
omercelikdev
force-pushed
the
fix/add-feature-multitenancy-smoke
branch
from
September 15, 2026 06:39
601e70b to
4ccf62f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
With #258–#260 in, the nightly
GmGrownRestshape builds and passes spec-lint — and fails its container smoke:Tenancy is fail-closed:
UseGoldpathMultiTenancyrefuses a request withoutX-Goldpath-Tenantwith 400, and it runs before auth. The template's smoke sends the header underUseMultiTenancy;goldpath add feature multitenancynever touched the smoke, so a grown app's own smoke test failed.GmGrownRestis the only shape that grows multitenancy through the CLI, and it had never reached its smoke before (restore, then GP1001, stopped it first). The published preview.8 CLI has the same gap.The fix
Same principle as #260 — the recipe does to template-owned code exactly what the template does:
app.CreateHttpClient("api");(a parity test reads it from the template),using Goldpath;in the smoke andGoldpath.Abstractionsin the smoke project,Proof
Stacking
On top of #260 (which is on #258 + #259). Merge order: #258, #259, #260, this. None merges until the GM matrix is green with all four (ADR-0008).
Docs:
docs/upgrades/0.1.0-preview.9.md(new section with the preview.8 hand fix),docs/guide/cli-reference.md.🤖 Generated with Claude Code