Skip to content

QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay#610

Open
michael-jihan-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
michael-jihan-qcom:purwa_kvm_6_18_y_may22
Open

QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay#610
michael-jihan-qcom wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
michael-jihan-qcom:purwa_kvm_6_18_y_may22

Conversation

@michael-jihan-qcom
Copy link
Copy Markdown

@michael-jihan-qcom michael-jihan-qcom commented May 22, 2026

Add a device tree overlay to enable EL2 boot support for the Purwa platform with CAMX configuration.

CRs-Fixed: 4546912

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4546912 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4546912
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@michael-jihan-qcom michael-jihan-qcom changed the title QCLINUX: arm64: dts: qcom: add hamoa CAMX EL2 overlay QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay May 22, 2026
Add a device tree overlay to enable EL2 boot support for the
Purwa platform with CAMX configuration.

CRs-Fixed: 4546912

Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com>
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4546912 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4546912
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@quic-vikramsa
Copy link
Copy Markdown

LGTM

@qlijarvis
Copy link
Copy Markdown

PR #610 — validate-patch

PR: #610

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #610 - QCLINUX: arm64: dts: qcom: add purwa CAMX EL2 overlay
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIPPED (not applicable)

Reason

This commit uses the QCLINUX: prefix, which indicates a vendor-only change with no upstream equivalent. According to the validate-patch skill scope, commits with QCLINUX:, PENDING:, or WORKAROUND: prefixes have no upstream lore link by design and cannot be validated against lore.kernel.org sources.

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit
Body preserves rationale Brief description provided
Fixes tag present/correct N/A Not a fix
Authorship preserved Proper From: and Signed-off-by:
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds new dtb target for purwa-camx-el2
arch/arm64/boot/dts/qcom/purwa-camx-el2.dtso New overlay for EL2 boot with CAMX IOMMU config

Observations

  • Commit structure: Well-formed with proper SPDX license, copyright, and sign-off
  • Content: Adds device tree overlay for Purwa platform EL2 boot support with camera ICP IOMMU configuration
  • CRs-Fixed tag: Present (4546912) — indicates internal tracking
  • No upstream validation required: This is vendor-specific platform enablement

Verdict

This is a vendor-only commit that does not require upstream validation. The commit message and diff structure are correct for a QCLINUX: prefixed change.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis
Copy link
Copy Markdown

PR #610 — checker-log-analyzer

PR: #610
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26284419200

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues exposed by new DTB build
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check QCLINUX: prefix present (required for non-qcom-next branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #610 — QCLINUX: arm64: dts: qcom: add purwa CAMX EL2 overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26284419200
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues exposed by new DTB build
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not accepted (known limitation)
tag-check QCLINUX: prefix present (required for non-qcom-next branches)

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: add purwa CAMX EL2 overlay Add a device tree overlay to enable EL2 boot support for the Purwa platform with CAMX configuration.
Commit summary does not start with a required prefix

Analysis:
The check-patch-compliance checker only accepts upstream-linkable prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:. The QCLINUX: prefix is a vendor-internal tag used for changes with no upstream equivalent. This is a known limitation of the checker — vendor-only commits will always fail this check.

Since this is a vendor-specific device tree overlay for the Purwa platform with CAMX EL2 configuration, and there is no upstream equivalent, the QCLINUX: prefix is correct and appropriate.

Fix: None required. This is expected behavior for vendor-only commits.

Note: The tag-check (Step 2.7 of the skill) confirms that the commit does have a valid subject prefix (QCLINUX:) as required for the target branch qcom-6.18.y (which is not qcom-next or qcom-next-staging).


❌ dtb-check

Root cause: Pre-existing tree issues in the base purwa-iot-evk.dtb and camera subsystem nodes are exposed when building the new composite DTB purwa-camx-el2.dtb.

Failure details:

Log Summary: Test failed

purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-req-mgr: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-jpeg: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,camera-main: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-isp: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-smmu: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-icp: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-cdm-intf: 'ranges' is a required property
purwa-camx-el2.dtb: soc@0 (simple-bus): qcom,cam-sync: 'ranges' is a required property

purwa-camx-el2.dtb: /soc@0/qcom,camera-main: failed to match any schema with compatible: ['qcom,camera_x1e80100']
purwa-camx-el2.dtb: /soc@0/qcom,cam-sync: failed to match any schema with compatible: ['qcom,cam-sync']

purwa-iot-evk.dtb: soc@0 (simple-bus): etm@13021000..etm@13821000: 'anyOf' conditional failed (×8 ETM nodes)
purwa-iot-evk.dtb: video-codec@aa00000 (qcom,x1p42100-iris): 'iommus' is a required property
purwa-iot-evk.dtb: ctcu@10001000 (qcom,hamoa-ctcu): failed to match any schema
purwa-iot-evk.dtb: funnel@13401000..replicator@13990000: compatible does not match schema (×10 CoreSight nodes)

Analysis:
These errors fall into two categories:

  1. Camera subsystem nodes missing 'ranges' property — These nodes (qcom,cam-req-mgr, qcom,cam-jpeg, qcom,camera-main, etc.) are defined in the base purwa-iot-evk.dtsi or included camera DTSI files. The simple-bus binding requires child nodes with #address-cells/#size-cells to declare a ranges property. This is a pre-existing tree issue, not introduced by this PR.

  2. CoreSight, video-codec, and CTCU binding errors — These are all from the base purwa-iot-evk.dtb and are pre-existing tree issues. The ETM nodes, video codec, CTCU, and CoreSight funnel/replicator/TMC nodes have binding validation failures that existed before this PR.

The new overlay purwa-camx-el2.dtso itself only adds 18 lines:

/ {
	fragment@0 {
		target-path = "/soc@0/qcom,cam-icp";
		__overlay__ {
			camera-firmware {
				...
			};
		};
	};
};

This overlay does not introduce any new binding violations. The failures are exposed because building purwa-camx-el2.dtb (which combines purwa-iot-evk-el2.dtb + purwa-evk-camx.dtbo + purwa-camx-el2.dtbo) triggers validation of the entire merged tree, including pre-existing issues.

Fix:
The camera subsystem 'ranges' property issue should be fixed in the base camera DTSI files (likely purwa-camera.dtsi or similar). Add ranges; (empty ranges for 1:1 address translation) to each camera subsystem node that has #address-cells and #size-cells:

qcom,cam-req-mgr {
	compatible = "qcom,cam-req-mgr";
	#address-cells = <1>;
	#size-cells = <0>;
	ranges;  // ← Add this
	...
};

However, this fix is outside the scope of this PR, as the issue is in the base tree, not in the new overlay.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/purwa-camx-el2.dtb

Verdict

2 blockers, but only 1 is actionable:

  1. check-patch-compliance failure — Expected for vendor-only commits with QCLINUX: prefix. No action needed.
  2. ⚠️ dtb-check failures — Pre-existing tree issues, not introduced by this PR. The new overlay itself is clean. Fixing the camera subsystem 'ranges' properties should be done in a separate PR targeting the base camera DTSI files.

Recommendation: The PR can be merged as-is if the team accepts that the dtb-check failures are pre-existing tree issues. Alternatively, fix the camera subsystem 'ranges' properties in the base tree first, then rebase this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants