Repository navigation
Optimize GDN state updates for decode - #1429
Merged
Rishin Raj (quic-rishinr) merged 2 commits intoOct 13, 2026
Merged
Rishin Raj (quic-rishinr) merged 2 commits into
Rishin Raj (quic-rishinr) merged 2 commits into
Conversation
quic-mkshirsa
marked this pull request as ready for review
October 9, 2026 19:03
quic-mkshirsa
force-pushed
the
fix/qwen3-5-moe-bsz1-decode-state-update
branch
from
October 9, 2026 19:18
b7ce44c to
7170ef3
Compare
Reorder full-batch inputs into physical cache-slot order once at the decoder boundary and restore logical output order afterward. Signed-off-by: Mrunal Kshirsagar <mkshirsa@qti.qualcomm.com>
quic-mkshirsa
force-pushed
the
fix/qwen3-5-moe-bsz1-decode-state-update
branch
from
October 9, 2026 20:18
7170ef3 to
bd914d1
Compare
Rishin Raj (quic-rishinr)
requested review from
Onkar Chougule (ochougul) and
Vinayak Baddi (vbaddi)
October 10, 2026 04:40
Contributor
|
Please add a reproducer config test for this issue, use qwen3.6 dummy random model for the test |
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Contributor
|
CI-Ready |
quic-mkshirsa
force-pushed
the
fix/qwen3-5-moe-bsz1-decode-state-update
branch
from
October 13, 2026 14:59
6ef0a56 to
92ec9a3
Compare
Rishin Raj (quic-rishinr)
merged commit Oct 13, 2026
dfc9156
into
qualcomm:release/v1.23.0
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generalizes Qwen3.5-MoE GDN retained-state updates to support full-batch kv_headpar decode for batch sizes 1, 2, 4, 8, and larger.
Problem
For kv_headpar decode, the compute batch covers the complete KV-cache batch. The gather/scatter operations are therefore unnecessary and cause compilation failures
for BS2 and BS4.
Solution
Validation