Repository navigation
Fix MDP partitioning for scoped ONNX aliases - #1430
Merged
Merged
Conversation
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Mamta Singh (quic-mamta)
suggested changes
Oct 12, 2026
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
asmigosw
requested review from
Amit Raj (quic-amitraj),
Hem Agnihotri (quic-hemagnih) and
Vinayak Baddi (vbaddi)
October 13, 2026 05:08
Mamta Singh (quic-mamta)
suggested changes
Oct 13, 2026
| ) | ||
| ) | ||
|
|
||
| mdp_json = generate_disagg_mdp_intersection_config( |
Contributor
There was a problem hiding this comment.
Please extend this regression to run precheck_and_autofix_mdp_partition_order() after generate_disagg_mdp_intersection_config() and assert /Gather_5 is still retained.
The production path runs this precheck after the scoped-alias repair, so the current test may pass even if the precheck later removes /Gather_5 before the final MDP JSON is written.
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
Signed-off-by: Asmita Goswami <asmigosw@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PP2 prefill compilation failures caused by scoped node-name collisions such as
/Gather_5and/language_model/Gather_5. The MDP generator now aligns alias partitions with the QAIC compiler dump and preserves compiler ordering.Verified both ONNX and intersection MDP strategies compile successfully.