Automate LLDB setup generation via make target#29
Conversation
| @@ -0,0 +1,23 @@ | |||
| THIS_MK := $(lastword $(MAKEFILE_LIST)) | |||
| H2DIR := $(abspath $(dir $(THIS_MK))/..) | |||
There was a problem hiding this comment.
H2DIR is provided by upper level makefile, please use it here.
|
|
||
| LLDB_PORT ?= 1234 | ||
|
|
||
| .PHONY: lldb-setup lldb-setup-clean |
There was a problem hiding this comment.
why do we need here .PHONY ?
There was a problem hiding this comment.
If we previously built "lldb-setup" with port 1234 and later wanted to change port from 1234 to 6789, we want to rewrite the file all over, though it exists in project already. Potentially we could cache the current port in other file, thought it was an overkill.
| lldb-setup: | ||
| $(MAKE) -f scripts/Makefile.lldb_setup LLDB_PORT=$(LLDB_PORT) | ||
|
|
||
| lldb-setup-clean: |
There was a problem hiding this comment.
It is not clear for me what is the clean flow here? Does 'make clean' remove the file ?
There was a problem hiding this comment.
We don't want to remove it on 'make clean' since it is not a target/archv dependent, the path always stays fixed.
lldb-setup line was added to .gitignore so we won't leave a stale copy on GitHub.
- Replace static lldb-setup with generated version - Add scripts/Makefile.lldb_setup to support automated creation - Update makefile to include 'make lldb-setup' and clean handling - Update .gitignore accordingly Usage: - Run 'make lldb-setup' to generate LLDB setup file automatically - Run 'make lldb-setup-clean' to remove generated artifacts Signed-off-by: Zeev Belinsky <zbelinsk@qti.qualcomm.com>
Remove redundant variable definitions (already defined in earlier Makefile workflow) Signed-off-by: zbelinsk <zbelinsk@qti.qualcomm.com>
Update docs for lldb usage. Signed-off-by: zbelinsk <zbelinsk@qti.qualcomm.com>
zbelinsk
force-pushed
the
automate_lldb_setup_creation
branch
from
6271dba to
9bcc99e
Compare
3 participants
Usage: