Skip to content

Shrink the receive read buffer from 16 MB to 64 KiB #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atsika wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Shrink the receive read buffer from 16 MB to 64 KiB #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/protocol/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ func (h *BaseHandler) ReceiveLoop() {
// records back to back, or a whole record plus the head of the next one.
// The accumulator below therefore lives OUTSIDE the read loop so that a
// record straddling two Read calls is reassembled rather than discarded.
buffer := make([]byte, 16*1024*1024)
// The read size only bounds how many iterations a large payload takes, never
// how it is framed, so it costs nothing to keep it small.
buffer := make([]byte, 64*1024)
acc := make([]byte, 0, HeaderSize+MaxPacketDataSize)

for {
Expand Down