Repository navigation
Fix revealjs diagram and image announcements - #15034
Open
jooyoungseo wants to merge 1 commit into
Open
jooyoungseo wants to merge 1 commit into
jooyoungseo wants to merge 1 commit into
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15033.
Backport image announcements to the bundled reveal.js 5.1.0 without upgrading the presentation framework:
styleandscriptcontents, including Mermaid's inline SVG stylesheet.fig-altis included alongside the caption.role="img"elements by their name rather than their presentational descendants, using the fix proposed in Fix screen reader image names and exclude SVG styles hakimel/reveal.js#3949.The readable source patch is included with an updater step that reapplies it and rebuilds the UMD/ESM bundles and source maps. The updater notes that the upstream PR is not yet merged and that both fixes must be present in a future reveal.js release before removing the backport.
This does not include the separate slide/fragment announcement changes in #15020 or change Graphviz's per-node title/label duplication.
Validation
revealjs-image-announcements.spec.ts --workers=1).js/reveal.jsdiffers.Checklist
I have (if applicable):
AI-assisted PR