Skip to content

don't treat programmatic selection changes as cursor movement in AceNodeView #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinushey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't treat programmatic selection changes as cursor movement in AceNodeView #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/editor/src/optional/ace/ace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,9 +530,11 @@ export class AceNodeView implements NodeView {

// If the cursor moves and we're in focus, ensure that the cursor is
// visible. Ace's own cursor visiblity mechanisms don't work in embedded
// editors.
// editors. Selection changes we make ourselves (this.updating) don't count:
// those come from ProseMirror syncing its selection into the editor, not
// from the user moving the cursor.
this.aceEditor.getSelection().on('changeCursor', () => {
if (this.dom.contains(document.activeElement) && !this.mouseDown) {
if (!this.updating && this.dom.contains(document.activeElement) && !this.mouseDown) {
this.cursorDirty = true;
}
});
Expand Down
Loading