Skip to content

Quarto notebook exporter (Positron)#999

Merged
seeM merged 1 commit into
mainfrom
feature/positron-notebook-export
Jun 11, 2026
Merged

Quarto notebook exporter (Positron)#999
seeM merged 1 commit into
mainfrom
feature/positron-notebook-export

Conversation

@seeM

@seeM seeM commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This PR sets up a "notebook exporter" for Quarto when inside Positron, which reuses the same implementation as the quarto.convertToQmd command (i.e. the quarto convert CLI). The quarto.convertToQmd command is also hidden when the exporter is registered (i.e. in Positron).

Until posit-dev/positron#14152 is merged, you'll have to test against that branch. Should have no effect in VS Code.

Demo:

Screen.Recording.2026-06-10.at.17.29.06.mov

I also added the outline of a test, but can't yet run it until we're able to test against Positron.

Related to posit-dev/positron#9791.

@seeM seeM requested a review from vezwork June 10, 2026 15:37
@posit-snyk-bot

posit-snyk-bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@vezwork vezwork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I glanced over the code and it looks good. Haven't tested yet, but if you've tried it in both Vscode and Positron, and after you add a changelog entry, please go ahead and merge (if you have permissions to). Otherwise I'll do a closer review, test, add changelog, and merge later.

@seeM seeM force-pushed the feature/positron-notebook-export branch from b602d94 to 72a9f0c Compare June 11, 2026 17:21
@seeM

seeM commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

@vezwork cool! In my testing, it works in Positron (on this branch) and doesn't break anything in VSCode. I'll go ahead and merge, but please let me know if you find any issues and I'll follow up with a fix.

@seeM seeM merged commit 657c04b into main Jun 11, 2026
4 of 5 checks passed
@seeM seeM deleted the feature/positron-notebook-export branch June 11, 2026 17:34
@vezwork

vezwork commented Jun 11, 2026

Copy link
Copy Markdown
Member

Tested the merged change in VSCode and there's no issues. If we run into any, we could consider putting activateNotebookExport behind a isPositron if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants