Improve UX for Mac and in general#17
Merged
bluestreak01 merged 12 commits intomasterfrom Apr 16, 2026
Merged
Conversation
# Conflicts: # src/app.rs # src/ui/help_dialog.rs # src/ui/mod.rs # src/ui/viewer_view.rs # src/viewer.rs
Only stash CI focus as pre_editor_focus if the user is actually on a CI panel when the download completes. Previously, if the user had Tab'd away to FilePanel while the download ran in the background, closing the editor would force focus back to the CI panel. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CI's @stable toolchain rolled over to rust 1.95, which added `collapsible_match` and tightened `unnecessary_sort_by`: - app.rs: collapse `"diff" => if git_info.is_some()` and two `MouseShiftClick => if click_in_...` into match guards. - app.rs: swap `sort_unstable_by(|a, b| b.1.cmp(&a.1))` for `sort_unstable_by_key(|b| Reverse(b.1))`. - event.rs: flatten the read→send block to build `Option<AppEvent>` once and send it once, instead of three send sites. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds a short "Fixing issues" section to CLAUDE.md making the rule explicit: pre-existing clippy / fmt / test failures get fixed in the current PR, not deferred. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bin-only clippy missed lints in test code. CLAUDE.md now says \`cargo clippy --all-targets -- -D warnings\` is the required check. Fixed every lint that check surfaced: - app.rs test: \`.len() > 0\` -> \`!is_empty()\`; avoid \`PathBuf::from(&home)\` owned-cmp by comparing against \`Path::new(&home)\`. - fs_ops/mod.rs tests: drop \`needless_borrows_for_generic_args\` \`&\` on \`path.join(...)\` args to \`symlink\`/\`fs::read\`. - gcs.rs test: remove unused \`prefix\` local. - nfs_client.rs: move \`copy_dir_recursive\` above \`#[cfg(test)] mod tests\` to satisfy \`items_after_test_module\`. - integration_remote.rs: drop unused \`webdav_available\` helper; \`.iter().any(|n| *n == x)\` -> \`.contains(&x)\`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bluestreak01
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary