Add Far Manager-style F9 menu, license CI, search dialog z-fix#21
Merged
bluestreak01 merged 2 commits intomasterfrom Apr 16, 2026
Merged
Add Far Manager-style F9 menu, license CI, search dialog z-fix#21bluestreak01 merged 2 commits intomasterfrom
bluestreak01 merged 2 commits intomasterfrom
Conversation
…alog z-order fix Introduces a dropdown menu bar (F9) with five categories—Left, File, Command, Options, Right—organizing all keyboard shortcuts into a discoverable hierarchy. The Left/Right menus show the current sort mode with a bullet indicator and let users set sort per-panel. Sort cycling moves to Ctrl+F9. Also adds cargo-deny license checking to CI (Apache-2.0 compatible deps only) and fixes the Ctrl+S search dialog being painted over by bottom panels. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…mensions - Clicking Search/Cancel buttons in Ctrl+S dialog now fires the action - Clicking checkboxes in Ctrl+S dialog now toggles them - Fix dropdown_click dimension mismatch with render (shared dropdown_rect) - Use .get() for bounds-safe sort field lookup in is_active_sort - Apply cargo fmt fixes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
•indicator and allow setting sort per-panel directly. Sort cycling moves to Ctrl+F9.cargo-denylicense checking to CI viadeny.toml, ensuring all dependencies remain Apache-2.0 compatible.rgb(46,39,64)torgb(74,50,100)for better highlight visibility in menus and dialogs.New files
src/ui/menu.rs— menu data, rendering, click detection, sort indicator, 14 testsdeny.toml— cargo-deny license allowlistChanged files
src/action.rs— newOpenMenu,SortByName/Size/Date(side)actionssrc/app.rs—MenuState, key/mouse interception, action dispatchsrc/panel/mod.rs—set_sort(field)methodsrc/ui/mod.rs— menu overlay rendering, search dialog z-order fixsrc/ui/footer.rs— F9 label: Sort → Menusrc/ui/help_dialog.rs— F9 → Menu in Application section, Ctrl+F9 → sort in File Operationssrc/theme.rs— dark theme selection bg contrast bump.github/workflows/ci.yml— license check jobTest plan
•on current sort, selecting a sort changes itcargo deny check licensespassescargo test— 900 tests pass (14 new menu tests)🤖 Generated with Claude Code