Reorder permissions block to follow GitHub Actions conventions#117
Merged
marten-seemann merged 2 commits intoci-workflow-permissionsfrom Dec 19, 2025
Merged
Reorder permissions block to follow GitHub Actions conventions#117marten-seemann merged 2 commits intoci-workflow-permissionsfrom
marten-seemann merged 2 commits intoci-workflow-permissionsfrom
Conversation
Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on deploy workflow permissions
Reorder permissions block to follow GitHub Actions conventions
Dec 19, 2025
marten-seemann
approved these changes
Dec 19, 2025
Member
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
wow, what a mindblowing change
marten-seemann
added a commit
that referenced
this pull request
Dec 19, 2025
* ci: add permissions to deploy workflow * Reorder permissions block to follow GitHub Actions conventions (#117) * Initial plan * Reorder permissions block to follow GitHub Actions best practices Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com> * Update .github/workflows/deploy.yml --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #115 to reorder the
permissionsblock in the deploy workflow to follow GitHub Actions standard ordering conventions.Changes
permissionsblock to appear afterontrigger block in.github/workflows/deploy.ymlname→on→permissions→jobsThis improves consistency and readability without changing functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.