chore(configure): drop the now-unused OPENCODE_K.model key - #225
Merged
Conversation
PR #221 stopped emitting a top-level `model` in the OpenCode-family configs, which left `OPENCODE_K.model` with no reader. Biome doesn't flag an unused object property, so it survived. Pure removal — the comment at the write site already explains why no pin is written, and CoDev Code shares this constant table via configureOpenCodeKind, so nothing else references it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#221 stopped writing a top-level
modelinto the OpenCode-family configs, which leftOPENCODE_K.model(src/lib/configure.ts) with no reader. Biome doesn't flag an unused object property, so it survived the PR.What changed
One line removed.
grep -rn "OPENCODE_K.model" src/now returns nothing — the only remainingOPENCODE_K.modelsreference is the provider models map, which is unrelated. CoDev Code shares this constant table throughconfigureOpenCodeKind, so the same removal covers both tools and there is no second symbol to clean up. The comment at the write site already explains why no pin is emitted, so nothing else needed rewording.No behavior change: the constant was never read, and
atob-encoded key tables are not part of any public surface.Testing
pnpm fix,pnpm typecheck,pnpm test(71 files, 1254 passed / 2 skipped),pnpm build && node dist/index.js --version→0.5.3. The pre-commit hook re-ran check/typecheck/test/build and passed.🤖 Generated with Claude Code