Share external DTD dictionary retry loader across DataDictionaryTest and MessageTest#1244
Draft
Copilot wants to merge 1 commit into
Draft
Share external DTD dictionary retry loader across DataDictionaryTest and MessageTest#1244Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot created this pull request from a session on behalf of
chrjohn
May 29, 2026 09:00
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataDictionaryTest.shouldLoadDictionaryWhenExternalDTDisEnabledcould fail on external DTD fetch timeouts, whileMessageTestalready had a retry-based mitigation for the same failure mode. This change applies the same timeout/retry behavior toDataDictionaryTestand centralizes the logic so both tests use one implementation.Shared external DTD loader
ExternalDtdDataDictionaryLoaderinquickfixj-baseto encapsulate:DataDictionaryTest
DataDictionary("FIX_External_DTD.xml", ...)construction with the shared loader so the test tolerates transient network timeouts when resolving the external DTD.MessageTest
DataDictionaryTestand avoiding duplicate logic.